Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #5

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

littlematch0123
Copy link
Contributor

if don't add the "pull-request: write" permission, the github action would fail, the Error message is "Resource not accssible by integration"
Screenshot 2023-02-11 at 08 00 19

if don't add the "pull-request: write" permission, the github action would fail, the Error message is "Resource not accssible by integration"
@tomwhross
Copy link
Owner

tomwhross commented Feb 13, 2023

@littlematch0123 First, thanks for much for the contribution, I really appreciate it! Second, can you briefly let me know the process/flow that was in-place when you caught this error? Specifically, were you working off of a forked repo? This says something about it being an issue with forks, but it's still new to me (I haven't tried running this in a while, though). I have no problem forcing the write permission since it's an action, just want to try to document it, thanks!

@littlematch0123
Copy link
Contributor Author

Thanks for your response. This below is the "Post comment" part in your action.

    - name: Post comment
      uses: mshick/add-pr-comment@v1
      if: ${{ steps.write-good.outputs.result }}
      with:
        message: |
          ${{ steps.write-good.outputs.result }}
        repo-token: ${{ secrets.GITHUB_TOKEN }}
        repo-token-user-login: 'github-actions[bot]' # The user.login for temporary GitHub tokens
        allow-repeats: false # This is the default

Screenshot 2023-02-14 at 20 45 41

You use the "mshick/add-pr-comment" action to add a comment to a pull request's issue. Note that "mshick/add-pr-comment" action need the write access
https://github.com/mshick/add-pr-comment#usage
Screenshot 2023-02-14 at 20 52 01
So, that's the reason for adding the "pull-request: write" permission

@littlematch0123
Copy link
Contributor Author

I'm an English learner, I'm not sure if what I said above is polite.
Please bear with me.

@tomwhross
Copy link
Owner

@littlematch0123 It was very polite and detailed, thank you for the info! I'll merge and issue a new release. Thanks again!

@tomwhross tomwhross merged commit 5bd8cd0 into tomwhross:main Feb 19, 2023
@tomwhross
Copy link
Owner

@littlematch0123 Sorry for the delay, and thanks again! Release 1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants